Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC 11 fixes #397

Merged
merged 3 commits into from
Mar 18, 2022
Merged

GCC 11 fixes #397

merged 3 commits into from
Mar 18, 2022

Conversation

mattw-nws
Copy link
Contributor

GCC changes certain assumptions in version 11 that causes compilation failures. This addresses all I could find. Notably, GCC 11 is what's currently the default in Homebrew (Mac and Linux).

Additions

  • Added #include <limits> and #include <stdexcept> explicitly where needed

Removals

  • None

Changes

  • Upped GoogleTest from tag for v1.10.0 to v1.11.0

Testing

  1. Compiled and ran all tests (except MPI/parallel tests) in a GCC 11 stack

Screenshots

Notes

  • None

Todos

  • Possible some issues still exist in parallel code, but this was harder to test in my test environment

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

  1. All non-parallel tests run with success, including all BMI language tests. Parallel tests not yet run. All passed except for routing, which probably isn't passing anywhere right now.

Target Environment support

  • Linux

@mattw-nws mattw-nws mentioned this pull request Mar 17, 2022
11 tasks
@hellkite500
Copy link
Member

Some combination of compiler version and gtest version have made the ubuntu runner angry. A quick look says we may need to

#include <algorithm>

in include/forcing/DeferredWrappedProvider.hpp so that it finds the correct string specialization.

@mattw-nws
Copy link
Contributor Author

Irritatingly, I just built a gcc-9 stack that should mimic that runner and it compiled just fine. :-\ Guess there's nothing for it but to try what you suggested and see if the runner likes it.

@hellkite500 hellkite500 merged commit 1333c23 into NOAA-OWP:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants