Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow the use of "all" to define catchment and nexus subsets #409

Merged
merged 1 commit into from
Apr 27, 2022
Merged

allow the use of "all" to define catchment and nexus subsets #409

merged 1 commit into from
Apr 27, 2022

Conversation

hellkite500
Copy link
Member

Due to various shell handling of empty strings, using this as an input to ngen can become complicated. This PR allows the string "all" to be used as an input for catchment and nexus subsets to indicate the use of the entire hydrofabric.

Changes

    • option to use all as an input string for catchment and nexus subsets. Empty strings still work as well.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • macOS

donaldwj
donaldwj approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@donaldwj donaldwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@mattw-nws mattw-nws merged commit 545af39 into NOAA-OWP:master Apr 27, 2022
@hellkite500 hellkite500 deleted the ngen-arg-update branch May 2, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldwj donaldwj donaldwj approved these changes

@stcui007 stcui007 Awaiting requested review from stcui007

@mattw-nws mattw-nws Awaiting requested review from mattw-nws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellkite500 @donaldwj @mattw-nws