Deal with shared lib file not found failures due to OS file extension mismatch #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causes
AbstractCLibBmiAdapter.hpp
to add the appropriate extension if missing (.so
or .dylib
) or try the alternative extension, for alibrary_file
if the path provided was not readable. This lets us collapse at least some places in tests that require multiple files/code just to get around this OS difference.Additions
AbstractCLibBmiAdapter.hpp
Removals
Changes
__macos
realization file fromRun surfacebmi plus cfebmi
test... does not delete this realization file... should we?Testing
Run surfacebmi plus cfebmi
now uses the Linux realization file (withextensionless path to dylib file) on macOS and Linux tests and succeeds..so
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support