Unit Conversion and Logging Tuneup

[mattw-nws]

Improves performance in unconvertable scenarios and cleans up logging and -DQUIET compliance.

[Short description explaining the high-level reason for the pull request]

Additions

Removals

Changes

• Conversions between incompatible units now have a nullptr "cached"... so the warning will happen faster without parsing the units strings again.
• Compressed unit conversion failure warnings into one line (from three), reducing effective noise level
• Unit conversion failures now explicitly say WARN: and do not include the word "error"... hopefully alleviating some confusion going forward.
• Caught a few more unit conversion messages that didn't respect -DQUIET
• Small tweak to non-units-related log messages that should be squelchable with -DQUIET.

Testing

1. Re-ran all existing tests

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

• Linux

[mattw-nws]

OH. Curious. I did not realize that this commit picked up the new TOPMODEL submodule pin. Hmm. I'm not even sure how to roll that back.

[mattw-nws]

Very strange behavior in this PR where the checks are not running... going to merge anyway because this same code passed tests previously... lets see if the post-merge tests run...?