Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interim Fix Issue #451 #457

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Interim Fix Issue #451 #457

merged 4 commits into from
Nov 9, 2022

Conversation

mattw-nws
Copy link
Contributor

Makes NetCDFPerFeatureDataProvider match behavior of CsvPerFeatureForcingProvider but both are probably wrong. Needs discussion but may need merging as an interim fix.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

donaldwj
donaldwj previously approved these changes Oct 17, 2022
Copy link
Contributor

@donaldwj donaldwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to update with some though if we ever require formulations that do not start on the same date.

@mattw-nws mattw-nws marked this pull request as ready for review November 9, 2022 18:10
@mattw-nws mattw-nws requested a review from donaldwj November 9, 2022 18:10
@mattw-nws mattw-nws merged commit 233b2ef into NOAA-OWP:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running with NetCDF forcing provider requires forcing data and start_time to be the same
2 participants