Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS runners - add netcdf-cxx and netcdf-fortran package to brew install #458

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

mattw-nws
Copy link
Contributor

@mattw-nws mattw-nws commented Oct 17, 2022

Add netcdf-cxx and netcdf-fortran package to brew install... looks like these were broken out into their own formulae about 15 days ago.

Additions

  • netcdf-cxx and netcdf-fortran brew install command for macOS build action
  • updates to similar brew install command in .gitpod.Dockerfile

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux
  • macOS

@mattw-nws mattw-nws marked this pull request as ready for review October 17, 2022 21:53
@mattw-nws mattw-nws changed the title Fix macOS runners - add netcdf-cxx package to brew install Fix macOS runners - add netcdf-cxx and netcdf-fortran package to brew install Oct 17, 2022
@hellkite500 hellkite500 merged commit 25adad0 into NOAA-OWP:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants