Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard interpreter util #478

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

stcui007
Copy link
Contributor

Fix a bug when building ngen with python turned off

Additions

Removals

Changes

test/realizations/catchments/Bmi_Multi_Formulation_Test.cpp

Testing

Building and running ngen

Screenshots

Notes

Todos

Checklist

  • [x ] PR has an informative and human-readable title
  • [x ] Changes are limited to a single goal (no scope creep)
  • [x ] Code can be automatically merged (no conflicts)
  • [x ] Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • [x ] Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • [x ] Linux

@mattw-nws
Copy link
Contributor

I think this won't merge because 61d07c7 is present from the other PR ... can you either rebase on master or rebase -i and remove that commit?

@stcui007
Copy link
Contributor Author

stcui007 commented Nov 18, 2022 via email

@stcui007 stcui007 force-pushed the Guard_InterpreterUtil branch from f226f5d to 9ea59c7 Compare November 18, 2022 22:41
@stcui007
Copy link
Contributor Author

stcui007 commented Nov 18, 2022 via email

@mattw-nws mattw-nws merged commit 8241e7a into NOAA-OWP:master Nov 21, 2022
@mattw-nws mattw-nws linked an issue Nov 21, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building ngen with python off fails with errors
2 participants