Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonlinear Reservoir Outlet Max Flow #57

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Nonlinear Reservoir Outlet Max Flow #57

merged 3 commits into from
Apr 17, 2020

Conversation

jdmattern
Copy link
Contributor

@jdmattern jdmattern commented Apr 14, 2020 •
edited
Loading

Adding nonlinear reservoir max outlet flow parameter.

Additions

Adding nonlinear reservoir max outlet flow parameter.

Testing

  1. Added corresponding unit test.

Notes

PR #56 needs to be merged before this one.

Fixes Issue #54

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@jdmattern jdmattern force-pushed the nonlinear-reservoir-outlet-max-flow branch from 1a81951 to 2c19ae3 Compare April 15, 2020 17:19
@jdmattern
Copy link
Contributor Author

PR #56 has been merged into master. I rebased on top of master from that merge.

@hellkite500 hellkite500 merged commit b830f78 into NOAA-OWP:master Apr 17, 2020
@hellkite500 hellkite500 mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellkite500 hellkite500 hellkite500 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdmattern @hellkite500