Resolve successive config mismatched NGenConfig.h #682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #681 by outputting the configured
NGenConfig.h
to the specified build directory instead of the source include directory.i.e., in the example given in #681, now we will have 2
NGenConfig.h
headers that correctly represent the build directory's configuration:Additions
NGen::config_header
that includes${build_directory}/include
.src/core
to${CMAKE_CURRENT_BINARY_DIR}/src/core/NGen_Python_Build_Versions.cpp
and adds it as a source toNGen::core
.Testing
Using the example above, built target
ngen
and targetall
successfully for both build configurations.Checklist