Improve error message for failure when opening CSV #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding errno and associate description for error to runtime_error thrown when failing to create ifstream for in CSVReader::getData().
PhilMiller
reviewed
Nov 27, 2023
PhilMiller
reviewed
Nov 27, 2023
Updating error messaging further in CSVReader::getData() to use errno for more detailed info when possible but fall back to general message if errno was not set by the failure.
PhilMiller
previously approved these changes
Nov 27, 2023
PhilMiller
reviewed
Nov 27, 2023
|
@PhilMiller, I did go ahead and add the include of |
PhilMiller
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
errnoand associate description for error to runtime_error thrown when failing to create ifstream for inCSVReader::getData().