Modify CMakelists.txt so that test_bmi_fortran can find iso_c

[stcui007]

This PR fix a compile error for extern/test_bmi_fortran where an error such as following occurs:

use bmif_2_0_iso
      1
Fatal Error: Can't open module file ‘bmif_2_0_iso.mod’ for reading at (1): No such file or directory

Additions

Removals

Changes

extern/test_bmi_fortran/CMakeLists.txt

Testing

1. Local Linux platform test

Screenshots

Notes

Todos

Checklist

• [x ] PR has an informative and human-readable title
• [x ] Changes are limited to a single goal (no scope creep)
• [x ] Code can be automatically merged (no conflicts)
• [x ] Code follows project standards (link if applicable)
• [x ] Passes all existing automated tests
• [x ] Any change in functionality is tested
• [x ] New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• [x ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• [x ] Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

• [x ] Linux

[program--]

Just two minor changes, then otherwise it's good!

[stcui007]

Good catch, Thank you!

…

On Wed, Feb 14, 2024 at 9:23 AM Justin Singh-M. - NOAA < ***@***.***> wrote: ***@***.**** requested changes on this pull request. Just two minor changes, then otherwise it's good! ------------------------------ In extern/test_bmi_fortran/CMakeLists.txt <#735 (comment)>: > @@ -16,7 +16,22 @@ target_sources(testbmifortranmodel PRIVATE ${_TESTBMIFORTRAN_OBJECTS}) target_compile_options(testbmifortranmodel PRIVATE -cpp -ffree-line-length-none) target_compile_definitions(testbmifortranmodel PRIVATE NGEN_ACTIVE) target_include_directories(testbmifortranmodel INTERFACE "${_TESTBMIFORTRAN_BINARY_DIR}/mod") -target_link_libraries(testbmifortranmodel PUBLIC iso_c_bmi) + +if(NGEN_IS_MAIN_PROJECT) + + # This ensures we can build NOAH-OWP-Modular with NGen support, but Comment should specify testbmifortranmodel, not NOAH-OWP-Modular ------------------------------ In extern/test_bmi_fortran/CMakeLists.txt <#735 (comment)>: > + #target_link_libraries(surfacebmi PUBLIC iso_c_bmi) + target_link_libraries(testbmifortranmodel PUBLIC iso_c_bmi) + #target_compile_definitions(surfacebmi PRIVATE NGEN_FORCING_ACTIVE NGEN_OUTPUT_ACTIVE NGEN_ACTIVE) Should remove the commented out lines — Reply to this email directly, view it on GitHub <#735 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACA4SROI2HWSRGHVBFACU23YTTJFHAVCNFSM6AAAAABDHHRYUKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBQGU4TCMJWG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[stcui007]

Sorry, I misunderstood. Now a corrected version is pushed up.

…

On Wed, Feb 14, 2024 at 2:25 PM Justin Singh-M. - NOAA < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In extern/test_bmi_fortran/CMakeLists.txt <#735 (comment)>: > + #target_link_libraries(surfacebmi PUBLIC iso_c_bmi) + target_link_libraries(testbmifortranmodel PUBLIC iso_c_bmi) + #target_compile_definitions(surfacebmi PRIVATE NGEN_FORCING_ACTIVE NGEN_OUTPUT_ACTIVE NGEN_ACTIVE) Your last commit removed the comment above the conditional, but I was talking about the comments of target_link_libraries and target_compile_definitions, which are directly referenced in this comment — Reply to this email directly, view it on GitHub <#735 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACA4SRNYGS64RMPTCE2YRY3YTUMSPAVCNFSM6AAAAABDHHRYUKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBRGI2DKMJUGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>