generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Formulation classes to reduce duplication and over-compilation #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on from duplicates per-language to Bmi_Module_Formulation
PhilMiller
force-pushed
the
phil/refactor-output
branch
from
March 20, 2024 18:39
30f42d9
to
d4be5a8
Compare
…reduce recompilation
PhilMiller
changed the title
reafctor: Move Formulation::get_output_line_for_timestep implementati…
Refactor Formulation classes to reduce duplication and over-compilation
Mar 20, 2024
PhilMiller
force-pushed
the
phil/refactor-output
branch
from
March 21, 2024 20:24
a6a4a03
to
670fe65
Compare
I recommend that this be reviewed commit-by-commit to make things much more comprehensible. |
program--
reviewed
Mar 21, 2024
program--
reviewed
Mar 21, 2024
program--
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @hellkite500 wants to review first before merging, but this looks great to me!
hellkite500
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Bmi_Module_Formulation.cpp
created to receive code moved out ofBmi_Module_Formulation.hpp
Removals
get_output_header_line
andget_output_line_for_timestep
are moved up toBmi_Module_Formulation
from the language-specific classesChanges
Bmi_Module_Formulation
from previously taking the concrete type of the underlying adapter classTesting
ctest
Checklist