Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve several minor bugs #791

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Resolve several minor bugs #791

merged 3 commits into from
Apr 15, 2024

Conversation

program--
Copy link
Contributor

@program-- program-- commented Apr 8, 2024 •
edited
Loading

Changes

  • Removes default link_key value for network class constructor.
  • Replaces a bitwise AND with logical AND in the geopackage read function.
  • Replaces usage of VLAs with std::vector in parallel_utils.h.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@program-- program-- marked this pull request as ready for review April 8, 2024 20:35
@PhilMiller PhilMiller merged commit dd3b91b into NOAA-OWP:master Apr 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@hellkite500 hellkite500 Awaiting requested review from hellkite500

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@program-- @PhilMiller