Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to Ubuntu 22.04 #792

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Apr 15, 2024

The current supported release of Ubuntu is 22.04, and the later 24.04 is just entering beta. We don't want to fall too far behind.

Changes

  • Update Linux OS image to Ubuntu 22.04
  • Update CMake options to quiet distracting warnings during configuration
  • Turn off Python for BMI C tests
  • (not reflected in code) Regenerate cached .venv for new OS and Python versions

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

  1. CI is the sole focus of this change

Target Environment support

  • Linux

@PhilMiller PhilMiller force-pushed the PhilMiller/ubuntu-22.04 branch from b623741 to c816d44 Compare April 15, 2024 22:54
@PhilMiller PhilMiller force-pushed the PhilMiller/ubuntu-22.04 branch from c816d44 to f87a87a Compare April 15, 2024 23:02
@PhilMiller PhilMiller marked this pull request as ready for review April 15, 2024 23:22
@PhilMiller PhilMiller requested a review from hellkite500 April 15, 2024 23:22
@PhilMiller
Copy link
Contributor Author

PhilMiller commented Apr 15, 2024

Happily, the compiler warnings and ASan failures we saw previously with Ubuntu 22.04 (#766) are now absent.

@PhilMiller
Copy link
Contributor Author

This no longer causes trouble because Github staff merged a workaround to the images: actions/runner-images#9491 (comment)

@hellkite500 hellkite500 merged commit 2902550 into NOAA-OWP:master Apr 17, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/ubuntu-22.04 branch April 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants