-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid Data Selector for Uniform Structured Grids #803
Conversation
…tes initialization
Co-authored-by: Phil Miller - NOAA <[email protected]>
- Removes GridDataSelector::bounding_box_ - Removes GridDataSelector::intersects_ - Replaces Extent class with BoundingBox class based on Boost.Geometry - Adds Boundary-based constructor to GridDataSelector - Modifies tests to adhere to new/modified classes
Everything in |
In the PR description, this wording is off:
|
Test looks good to me, modulo my potential confusion or the possibility of making it a little bit stricter. So, I think this is pretty much ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selector ends up holding a span of the point locations to be retrieved, unless I misread this. This design can probably be adapted to mesh formats although the locations will become two dimensional indices one dimension indicating postion, the other [node, edge, face]
This PR implements Cell, Point, Boundary, and Bounding Box based constructors for a
GridDataSelector
.Additions
DataProvider<Cell, GridDataSelector>
TODOs
TODOs are documented alongside code documentation.
Testing
Unit tests pass locally with GCC 13.2.1 and Clang 17
Checklist
Target Environment support