Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Data Selector for Uniform Structured Grids #803

Merged
merged 13 commits into from
May 8, 2024

Conversation

program--
Copy link
Contributor

@program-- program-- commented Apr 22, 2024

This PR implements Cell, Point, Boundary, and Bounding Box based constructors for a GridDataSelector.

Additions

  • GridDataSelector class
  • Cell-based constructor for GridDataSelector
  • Extent-based constructor for GridDataSelector
  • Point-based constructor for GridDataSelector
  • GridDataSelector tests with an example gridded data provider deriving from DataProvider<Cell, GridDataSelector>

TODOs

TODOs are documented alongside code documentation.

Testing

Unit tests pass locally with GCC 13.2.1 and Clang 17

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux

@program-- program-- requested a review from hellkite500 April 22, 2024 22:28
@program-- program-- marked this pull request as ready for review April 26, 2024 19:58
Co-authored-by: Phil Miller - NOAA <[email protected]>
- Removes GridDataSelector::bounding_box_
- Removes GridDataSelector::intersects_
- Replaces Extent class with BoundingBox class based on Boost.Geometry
- Adds Boundary-based constructor to GridDataSelector
- Modifies tests to adhere to new/modified classes
@PhilMiller
Copy link
Contributor

Everything in GridDataSelector.hpp looks good to me. Just need to go over the tests.

@PhilMiller
Copy link
Contributor

In the PR description, this wording is off:

GridDataSelector class, deriving from DataProvider<Cell, GridDataSelector>.

@PhilMiller
Copy link
Contributor

Test looks good to me, modulo my potential confusion or the possibility of making it a little bit stricter. So, I think this is pretty much ready to go.

donaldwj
donaldwj previously approved these changes May 7, 2024
Copy link
Contributor

@donaldwj donaldwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector ends up holding a span of the point locations to be retrieved, unless I misread this. This design can probably be adapted to mesh formats although the locations will become two dimensional indices one dimension indicating postion, the other [node, edge, face]

@donaldwj donaldwj merged commit c854603 into NOAA-OWP:master May 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants