Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete defunct DataSelector classes #807

Merged

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Apr 30, 2024

The uses of these classes were deleted in commit acea24d in 2022. Clear them out so they don't distract from on-going work

Removals

  • Classes {BMI,CSV,NetCDF}DataSelector that were all empty subclasses of CatchmentAggrDataSelector

Changes

  • {CSV,NetCDF}DataProvider tests modified to use base class instead of specific derived classes

Testing

  1. CI

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller force-pushed the PhilMiller/delete-old-dataselectors branch from 204a617 to 17259b6 Compare April 30, 2024 19:02
@PhilMiller PhilMiller marked this pull request as ready for review April 30, 2024 19:24
@PhilMiller PhilMiller merged commit ceb7c01 into NOAA-OWP:master Apr 30, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/delete-old-dataselectors branch April 30, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants