Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old macros with consistent NGEN_WITH_FOO #814

Merged

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented May 3, 2024

Replace all NGen-specific build condition macros that weren't in the current standard form in the codebase with the standard form.

Resolves #813

Testing

  1. Local testing with various flags enabled/disabled
  2. CI

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller
Copy link
Contributor Author

Grrr, builds failing due to include paths for much of the codebase not reaching NGenConfig.h. Gotta play with CMake more to figure that out.

@PhilMiller PhilMiller force-pushed the PhilMiller/813-replace-old-macros branch from 18f4ab1 to 1e5372d Compare May 5, 2024 01:00
@PhilMiller PhilMiller marked this pull request as ready for review May 7, 2024 01:31
donaldwj
donaldwj previously approved these changes May 7, 2024
Copy link
Contributor

@donaldwj donaldwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had wanted this changed for a while, didn't ever have time to edit 50 files for it.

@donaldwj donaldwj merged commit 8523c17 into NOAA-OWP:master May 7, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/813-replace-old-macros branch May 8, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update internal use of old macros
2 participants