generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace old macros with consistent NGEN_WITH_FOO #814
Merged
donaldwj
merged 20 commits into
NOAA-OWP:master
from
PhilMiller:PhilMiller/813-replace-old-macros
May 7, 2024
Merged
Replace old macros with consistent NGEN_WITH_FOO #814
donaldwj
merged 20 commits into
NOAA-OWP:master
from
PhilMiller:PhilMiller/813-replace-old-macros
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a typo of '#ifdef NGEN_C_LIB_ACTIVE' that missed the intended macro
Grrr, builds failing due to include paths for much of the codebase not reaching |
PhilMiller
force-pushed
the
PhilMiller/813-replace-old-macros
branch
from
May 5, 2024 01:00
18f4ab1
to
1e5372d
Compare
PhilMiller
requested review from
program--,
donaldwj,
hellkite500 and
robertbartel
May 7, 2024 01:31
10 tasks
donaldwj
previously approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had wanted this changed for a while, didn't ever have time to edit 50 files for it.
donaldwj
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all NGen-specific build condition macros that weren't in the current standard form in the codebase with the standard form.
Resolves #813
Testing
Checklist