Clean up code for Formulation in advance of Coastal introduction#815

Merged

donaldwj merged 11 commits intoNOAA-OWP:masterfrom PhilMiller:PhilMiller/formulation-cleanup-pre-coastal

May 10, 2024

+142-645

Commits on May 8, 2024

Delete never-used Nexus_Manager code that uses class Formulation unexpectedly
PhilMiller
committed
Test: Specify Catchment_Formulation when iterating over (catchment) Formulation_Manager entities
PhilMiller
committed
Refactor: Move virtual get_response from Formulation to Catchment_Formulation
PhilMiller
committed
Refactor: Move virtual get_output_header_line from Formulation to Catchment_Formulation
PhilMiller
committed
Refactor: Move virtual get_output_line_for_timestep from Formulation to Catchment_Formulation
PhilMiller
committed
Make non-overridden protected member functions non-virtual
PhilMiller
committed
Bmi_Formulation: Share single copies of required and optional configuration parameter vectors
PhilMiller
committed
Refactor: consolidate duplicate implementations into Bmi_Module_Formulation::get_response
PhilMiller
committed
Refactor Bmi_Formulation: Share duplicate implementations of scalar get_var_value_as_double
PhilMiller
committed
Remove scalar overload of get_var_value_as_double
PhilMiller
committed
Typo fix
PhilMiller
committed