Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ET submodule for .gitignore #838

Merged

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Jun 20, 2024

Make git status not note the presence of extern/evapotranspiration/evapotranspiration/cmake_build

Changes

  • Update ET's submodule to a commit that includes cmake_build in its .gitignore

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller requested a review from robertbartel June 20, 2024 18:15
@PhilMiller PhilMiller changed the title Update ET for .gitignore Update ET submodule for .gitignore Jun 20, 2024
@PhilMiller PhilMiller requested a review from hellkite500 June 21, 2024 18:27
@hellkite500 hellkite500 merged commit d5a0171 into NOAA-OWP:master Jun 21, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/update-evapotranspiration branch June 21, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants