Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse global model params #873

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Don't reuse global model params #873

merged 2 commits into from
Aug 16, 2024

Conversation

hellkite500
Copy link
Member

@hellkite500 hellkite500 commented Aug 16, 2024

Fixing bug in reuse of global model_params when linking external data from a global formulation definition

Changes

  • Copy global formulation config before modifying with link_external

Testing

  1. Tested on realization provided in Formulation Data Provider providing wrong data #871 and ensured each feature on the BMI receiving end has correct area values

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • MacOS

@hellkite500 hellkite500 changed the title fix: don't reuse global model params, fixes #181 and #182 Don't reuse global model params Aug 16, 2024
@hellkite500 hellkite500 merged commit ad667f1 into master Aug 16, 2024
19 checks passed
@hellkite500 hellkite500 deleted the fix-182 branch August 16, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants