don't initialize ngen submodule after copying in local code #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests will fail until the action is updated in ngen: |
madMatchstick
approved these changes
Mar 20, 2024
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, dependent on NOAA-OWP/ngen#769, would allow the integration test to use the current checked out code in place of the submodule checkout by using the new "initialize" input. This also passes custom cmake build flags along to the submodule build action to configure the build.
This allows the ngen build to use the static submodule commits (which have hopefully been tested) and only use the current NOM PR code to run the test with. Customization of other components is possible, but not in scope here and may not be a good idea in general.
Closes #104