provide option to skip initializing and add general build flags to sub-module build #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaraney
approved these changes
Mar 20, 2024
PhilMiller
approved these changes
Mar 20, 2024
madMatchstick
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
@hellkite500 - Thanks for spearheading this.
For reference, this will require changes to NOM (thanks for the template/pr#105), topmodel & pet workflows.
program--
approved these changes
Mar 20, 2024
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide some flexibility in the submodule build action, so a caller can avoid initializing the module in case they want to replace the submodule code with custom code before the compile steps.
Also take a generic build flag input allowing custom cmake flags such as macro defines to be passed to to the cmake configure step.
This would replace #768, which would address noaa-owp/noaa-owp-modular#104 by allowing custom workflows to change to replace the code being built by the action.
Should also strongly consider adding a
workdirinput to allow acd ${{ inputs.workdir }}before the configure/build steps. This would allow some customization with the actions/checkout which allows checking out different repositories to new directories, but the build action would need to know which path to initiate the build steps under.