Add option to AvailabilityManager:NightCycle to run just until the zone temperature recovers #6151 #6179
Conversation
|
This issue (new feature) is ready for review. The CI machine shows 14 idfs failure due to diffs. These diffs are audit and Table big diffs that are caused by new field addition in "AvailabilityManager:NightCycle" object. Some of these example files has multiple NightCycle objects. These diffs are expected. |
mjwitte
added
IDDChange
idd/Energy+.idd.in
Outdated
| \type object-list | ||
| \object-list ZoneAndZoneListNames | ||
|
|
||
|
|
There was a problem hiding this comment.
Random double space I'll clean up
| @@ -74242,25 +74242,32 @@ AvailabilityManager:NightCycle, | |||
| N1 , \field Thermostat Tolerance | |||
| \default 1.0 | |||
| \units deltaC | |||
| A5 , \field Cycling Run Time Control Type | |||
There was a problem hiding this comment.
I added the transition rule for this and tested it. ✔️
| @@ -740,17 +744,33 @@ namespace SystemAvailabilityManager { | |||
| ErrorsFound = true; | |||
| }} | |||
|
|
|||
| // Cycling Run Time Control Type | |||
| if ( !lAlphaFieldBlanks( 5 ) ) { | |||
| { auto const SELECT_CASE_var( MakeUPPERCase( cAlphaArgs( 5 ) ) ); | |||
There was a problem hiding this comment.
In the future, try to avoid propagating the SELECT_CASE_var code. It was really just used when the Fortran code was changed over but lingered. Nbd for here, just don't add any others in the future. 👍
| SystemAvailabilityManager::CalcNCycSysAvailMgr( SysAvailNum, PriAirSysNum, AvailStatus ); | ||
| // Check that the system is no action mode, zone air temp is within T tolerance limits of 0.05, 25.04 < 25.0 + 0.05 | ||
| EXPECT_EQ( DataHVACGlobals::NoAction, SystemAvailabilityManager::NCycSysAvailMgrData( 1 ).AvailStatus ); | ||
| } |
There was a problem hiding this comment.
No newline at end; I"ll add it.
Issue #6151
Pull request overview
This issue adds option to AvailabilityManager:NightCycle to run just until the zone temperature recovers with two more Cycling Run Time Control Types. This feature enhances existing capability. This is not a defect and diffs is not expected. But audit and table files diffs are expected due to new input field addition. About 87 idfs were transitioned manually. A transition rule md file and unit tests have been added.
Work Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.