Hour angle filter #375
Merged
Hour angle filter #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for pandas 2.0.0 compatibility
…nto hour_angle_filter
cdeline
reviewed
May 25, 2023
rdtools/analysis_chains.py
Outdated
| @@ -464,6 +464,18 @@ def _call_clearsky_filter(filter_string): | |||
| f = filtering.clip_filter( | |||
| self.pv_power, **self.filter_params['clip_filter']) | |||
| filter_components['clip_filter'] = f | |||
| if 'hour_angle_filter' in self.filter_params: | |||
| if self.pvlib_location is None: | |||
There was a problem hiding this comment.
if undefined, self.pvlib_location won't be None, it'll actually return an AttributeError. I've got a fix for the handful of places this crops up. There's another bug of this nature on the check for tilt and azimuth too...
cdeline
approved these changes
May 25, 2023
|
Our tests are failing because the pvlib clearsky function doesn't seem to like our artificial test case. Will revisit when it comes time for a more stable release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__.py