Hour angle filter

.github/workflows/pytest.yaml

@@ -43,4 +43,4 @@ jobs:
         pip install ${{ matrix.env }}
     - name: Test with pytest ${{ matrix.env }}
       run: |
-        pytest
+        pytest

docs/sphinx/source/changelog.rst

@@ -1,6 +1,7 @@
 RdTools Change Log
 ==================
 .. include:: changelog/v2.2.0-beta.1.rst
+.. include:: changelog/v2.1.5.rst
 .. include:: changelog/v2.1.4.rst
 .. include:: changelog/v2.2.0-beta.0.rst
 .. include:: changelog/v2.1.3.rst

docs/sphinx/source/changelog/v2.1.5.rst

@@ -0,0 +1,13 @@
+*************************
+v2.1.5 (May 16, 2023)
+*************************
+
+Bug Fixes
+---------
+* Add support for pandas 2.0 (:issue:`361`, :pull:`362`)
+
+
+Contributors
+------------
+* Kevin Anderson (:ghuser:`kanderso-nrel`)
+* Michael Deceglie (:ghuser:`mdeceglie`)

rdtools/analysis_chains.py

@@ -464,6 +464,18 @@ def _call_clearsky_filter(filter_string):
             f = filtering.clip_filter(
                 self.pv_power, **self.filter_params['clip_filter'])
             filter_components['clip_filter'] = f
+        if 'hour_angle_filter' in self.filter_params:
+            if self.pvlib_location is None:
+                raise ValueError(
+                    'The pvlib location must be provided using set_clearsky() '
+                    'or by directly setting TrendAnalysis.pvlib_location '
+                    'in order to use the hour_angle_filter')
+            loc = self.pvlib_location
+            f = filtering.hour_angle_filter(
+                energy_normalized, loc.latitude, loc.longitude,
+                 **self.filter_params['hour_angle_filter'])
+            filter_components['hour_angle_filter'] = f
+
         if case == 'clearsky':
             filter_components['pvlib_clearsky_filter'] = _call_clearsky_filter('pvlib_clearsky_filter')
         if 'sensor_pvlib_clearsky_filter' in self.filter_params:

rdtools/degradation.py

@@ -38,7 +38,7 @@ def degradation_ols(energy_normalized, confidence_level=68.2):
 
     # calculate a years column as x value for regression, ignoring leap years
     day_diffs = (df.index - df.index[0])
-    df['days'] = day_diffs.astype('timedelta64[s]') / (60 * 60 * 24)
+    df['days'] = day_diffs / pd.Timedelta('1d')
     df['years'] = df.days / 365.0
 
     # add intercept-constant to the exogeneous variable
@@ -123,7 +123,7 @@ def degradation_classical_decomposition(energy_normalized,
 
     # calculate a years column as x value for regression, ignoring leap years
     day_diffs = (df.index - df.index[0])
-    df['days'] = day_diffs.astype('timedelta64[s]') / (60 * 60 * 24)
+    df['days'] = day_diffs / pd.Timedelta('1d')
     df['years'] = df.days / 365.0
 
     # Compute yearly rolling mean to isolate trend component using
@@ -292,7 +292,7 @@ def degradation_year_on_year(energy_normalized, recenter=True,
                        tolerance=pd.Timedelta('8D')
                        )
 
-    df['time_diff_years'] = (df.dt - df.dt_right).astype('timedelta64[h]') / 8760.0
+    df['time_diff_years'] = (df.dt - df.dt_right) / pd.Timedelta('365d')
     df['yoy'] = 100.0 * (df.energy - df.energy_right) / (df.time_diff_years)
     df.index = df.dt
 

rdtools/filtering.py

@@ -527,8 +527,9 @@ def logic_clip_filter(power_ac,
     # series sampling frequency is less than 95% consistent.
     _check_data_sampling_frequency(power_ac)
     # Get the sampling frequency of the time series
-    time_series_sampling_frequency = power_ac.index.to_series().diff()\
-        .astype('timedelta64[m]').mode()[0]
+    time_series_sampling_frequency = (
+        power_ac.index.to_series().diff() / pd.Timedelta('60s')
+    ).mode()[0]
     # Make copies of the original inputs for the cases that the data is
     # changes for clipping evaluation
     original_time_series_sampling_frequency = time_series_sampling_frequency
@@ -754,8 +755,7 @@ def xgboost_clip_filter(power_ac,
     # series sampling frequency is less than 95% consistent.
     _check_data_sampling_frequency(power_ac)
     # Get the most common sampling frequency
-    sampling_frequency = int(power_ac.index.to_series().diff()
-                             .astype('timedelta64[m]').mode()[0])
+    sampling_frequency = int((power_ac.index.to_series().diff() / pd.Timedelta('60s')).mode()[0])
     freq_string = str(sampling_frequency) + "T"
     # Min-max normalize
     # Resample the series based on the most common sampling frequency
@@ -948,3 +948,18 @@ def directional_tukey_filter(series, roll_period=pd.to_timedelta('7 Days'), k=1.
             ((backward_dif > backward_dif_lower) & (backward_dif < backward_dif_upper))
             )
     return mask
+
+
+def hour_angle_filter(series, lat, lon, min_hour_angle=-30, max_hour_angle=30):
+    '''
+    Creates a filter based on the hour angle of the sun (15 degrees per hour)
+    '''
+
+    times = series.index
+    spa = pvlib.solarposition.get_solarposition(times, lat, lon)
+    eot = spa['equation_of_time']
+    hour_angle = pvlib.solarposition.hour_angle(times, lon, eot)
+    hour_angle = pd.Series(hour_angle, index=times)
+    mask = (hour_angle >= min_hour_angle) & (hour_angle <= max_hour_angle)
+
+    return mask

rdtools/test/availability_test.py

@@ -162,7 +162,7 @@ def difficult_data():
 
     # generate a plausible clear-sky power signal
     times = pd.date_range('2019-01-01', '2019-01-06', freq='15min',
-                          tz='US/Eastern', closed='left')
+                          tz='US/Eastern')
     location = pvlib.location.Location(40, -80)
     clearsky = location.get_clearsky(times, model='haurwitz')
     # just scale GHI to power for simplicity

rdtools/test/degradation_test.py

@@ -34,7 +34,7 @@ def get_corr_energy(cls, rd, input_freq):
             freq = input_freq
 
         x = pd.date_range(start=start, end=end, freq=freq)
-        day_deltas = (x - x[0]).astype('timedelta64[s]') / (60.0 * 60.0 * 24)
+        day_deltas = (x - x[0]) / pd.Timedelta('1d')
         noise = (np.random.rand(len(day_deltas)) - 0.5) / 1e3
 
         y = 1 + daily_rd * day_deltas + noise

requirements.txt

@@ -18,7 +18,7 @@ pvlib==0.9.0
 pyparsing==2.4.7
 python-dateutil==2.8.1
 pytz==2019.3
-arch==4.11
+arch==5.5.0
 filterpy==1.4.5
 requests==2.25.1
 retrying==1.3.3

setup.py

@@ -35,7 +35,7 @@
     'pytest >= 3.6.3',
     'coverage',
     'flake8',
-    'nbval',
+    'nbval==0.9.6',  # https://github.com/computationalmodelling/nbval/issues/194
     'pytest-mock',
 ]