Add notifications column to grant permissions index. #792 (#962)

* Add notifications column to grant permissions index. #792
* add specs for on_off_boolean helper. #792
* add specs on index row for grant_permissions. #792

app/helpers/application_helper.rb

@@ -32,6 +32,11 @@ def title_tag_content(page_title: '')
     page_title.empty? ? base_title : "#{page_title} | #{base_title}"
   end
 
+  # Boolean value changes
+  def on_off_boolean(boolean)
+    boolean ? 'On' : 'Off'
+  end
+
   # Dates
   def date_mmddyyyy(date)
     date.blank? ? '' : date.strftime('%m/%d/%Y')

app/views/grant_permissions/index.html.haml

@@ -41,14 +41,18 @@
           %th
             Role
           %th
+            Notifications
+          %th
 
       %tbody
         - @grant_permissions.each do |grant_permission|
           - grant_permission_user_name = full_name(grant_permission.user)
-          %tr
+          %tr{ id: "#{dom_id(grant_permission)}" }
             %td
               = grant_permission_user_name
             %td
               = grant_permission.role.capitalize
+            %td
+              = on_off_boolean(grant_permission.submission_notification)
             %td
               = render partial: "#{current_user.get_role_by_grant(grant: @grant)}_links", locals: { grant_permission: grant_permission, grant: @grant, grant_permission_user_name: grant_permission_user_name }

spec/helpers/application_helper_spec.rb

@@ -36,4 +36,18 @@ def excel_worksheet_reserved_characters
       expect(title_tag_content(page_title: 'Page Name')).to eql 'Page Name | TEST'
     end
   end
+
+  context 'booleans' do
+    describe '#on_off_boolean(boolean)' do
+      it 'returns On when given a true boolean' do
+        boolean = true
+        helper.on_off_boolean(boolean).should eql("On")
+      end
+
+      it 'returns Off when given a false boolean' do
+        boolean = false
+        helper.on_off_boolean(boolean).should eql("Off")
+      end
+    end
+  end
 end

spec/system/grant_permissions/grant_permissions_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+include ApplicationHelper
 include UsersHelper
 
 RSpec.describe 'GrantPermissions', type: :system, js: true do
@@ -23,23 +24,30 @@
   describe 'grant editor user' do
     before(:each) do
       login_as(@grant_editor, scope: :saml_user)
+      visit grant_grant_permissions_path(@grant)
     end
 
     context '#index' do
       scenario 'includes link to add permission' do
-        visit grant_grant_permissions_path(@grant)
         expect(page).to have_link 'Grant access to another user', href: new_grant_grant_permission_path(@grant)
       end
 
       scenario 'includes edit link, excludes delete link' do
-        visit grant_grant_permissions_path(@grant)
         expect(page).to have_link 'Edit',   href: edit_grant_grant_permission_path(@grant, @grant_admin_role)
         expect(page).not_to have_link 'Delete', href: grant_grant_permission_path(@grant, @grant_admin_role)
         expect(page).to have_link 'Edit',   href: edit_grant_grant_permission_path(@grant, @grant_editor_role)
         expect(page).not_to have_link 'Delete', href: grant_grant_permission_path(@grant, @grant_editor_role)
         expect(page).to have_link 'Edit',   href: edit_grant_grant_permission_path(@grant, @grant_viewer_role)
         expect(page).not_to have_link 'Delete', href: grant_grant_permission_path(@grant, @grant_viewer_role)
       end
+
+      scenario 'includes information in grant admin table row' do
+        within("tr#grant_permission_#{@grant_admin_role.id}") do
+          expect(page).to have_content(full_name(@grant_admin))
+          expect(page).to have_content(@grant_admin_role.role.capitalize)
+          expect(page).to have_content(on_off_boolean(@grant.grant_permissions.role_admin.first.submission_notification))
+        end
+      end
     end
 
     context '#edit' do