Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notifications column to grant permissions index. #792 #962

Merged
merged 4 commits into from
Jul 15, 2022
Merged

Add notifications column to grant permissions index. #792 #962

merged 4 commits into from
Jul 15, 2022

Conversation

mattbaumann1
Copy link
Collaborator

closes #792

@mattbaumann1 mattbaumann1 requested a review from jseraf July 13, 2022 22:43
@mattbaumann1 mattbaumann1 self-assigned this Jul 13, 2022
jseraf
jseraf requested changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@jseraf jseraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth adding specs -- system specs to confirm output, maybe a helper spec?

@mattbaumann1 mattbaumann1 merged commit eefb3e5 into develop Jul 15, 2022
@mattbaumann1 mattbaumann1 deleted the task/notifications-on-permissions-tab-792 branch July 16, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jseraf jseraf jseraf approved these changes

Assignees

@mattbaumann1 mattbaumann1

Labels
grant-permissions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show grant submission notification in table on Permissions tab
2 participants
@mattbaumann1 @jseraf