ci: Cleanup required tests #10773
Merged
ci: Cleanup required tests #10773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Koenig <[email protected]>
|
[🤖]: Hi @ko3n1g 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
pablo-garay
reviewed
Oct 5, 2024
|
[🤖]: Hi @ko3n1g 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
pablo-garay
reviewed
Oct 6, 2024
.github/workflows/cicd-main.yml
Outdated
| @@ -5223,7 +5223,6 @@ jobs: | |||
| - L0_Unit_Tests_GPU_Hydra | |||
| #- OPTIONAL_L0_Unit_Tests_GPU_Lightning | |||
| - L0_Unit_Tests_GPU_Others | |||
|
|
|||
There was a problem hiding this comment.
This line was deliberately here to separate CPU from GPU for better readability/awareness
There was a problem hiding this comment.
So can we revert it back please if you dont mind, at least it helps me in readability :)
Signed-off-by: Oliver Koenig <[email protected]>
ko3n1g
force-pushed
the
ko3n1g/ci/optional-tests
branch
from
789a66b to
3aa0f52
Compare
|
[🤖]: Hi @ko3n1g 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
pablo-garay
approved these changes
Oct 7, 2024
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* ci: Cleanup required tests Signed-off-by: Oliver Koenig <[email protected]> * remove L0_Setup_Test_Data_And_Models Signed-off-by: Oliver Koenig <[email protected]> * remove duplicate record Signed-off-by: Oliver Koenig <[email protected]> * add missing `if` Signed-off-by: Oliver Koenig <[email protected]> * feedback Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>
yashaswikarnati
pushed a commit
that referenced
this pull request
Oct 20, 2024
* ci: Cleanup required tests Signed-off-by: Oliver Koenig <[email protected]> * remove L0_Setup_Test_Data_And_Models Signed-off-by: Oliver Koenig <[email protected]> * remove duplicate record Signed-off-by: Oliver Koenig <[email protected]> * add missing `if` Signed-off-by: Oliver Koenig <[email protected]> * feedback Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* ci: Cleanup required tests Signed-off-by: Oliver Koenig <[email protected]> * remove L0_Setup_Test_Data_And_Models Signed-off-by: Oliver Koenig <[email protected]> * remove duplicate record Signed-off-by: Oliver Koenig <[email protected]> * add missing `if` Signed-off-by: Oliver Koenig <[email protected]> * feedback Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* ci: Cleanup required tests Signed-off-by: Oliver Koenig <[email protected]> * remove L0_Setup_Test_Data_And_Models Signed-off-by: Oliver Koenig <[email protected]> * remove duplicate record Signed-off-by: Oliver Koenig <[email protected]> * add missing `if` Signed-off-by: Oliver Koenig <[email protected]> * feedback Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information