ci: Cleanup required tests (NVIDIA#10773)

* ci: Cleanup required tests Signed-off-by: Oliver Koenig <[email protected]> * remove L0_Setup_Test_Data_And_Models Signed-off-by: Oliver Koenig <[email protected]> * remove duplicate record Signed-off-by: Oliver Koenig <[email protected]> * add missing `if` Signed-off-by: Oliver Koenig <[email protected]> * feedback Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>
paarthneekhara · Jan 18, 2025 · 3ecc0fd · 3ecc0fd
1 parent cdccd76
commit 3ecc0fd
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/.github/workflows/cicd-main.yml b/.github/workflows/cicd-main.yml
@@ -3660,10 +3660,10 @@ jobs:
         model.data.validation_ds.output_file_path_prefix="/home/TestData/nlp/megatron_ir/working_dir/val_embs" \
         model.data.train_ds.file_names=[/home/TestData/nlp/megatron_ir/train.jsonl]
 
-  OPTIONAL_L2_Megatron_GPT_Embedding:
+  L2_Megatron_GPT_Embedding:
     needs: [cicd-test-container-setup]
     uses: ./.github/workflows/_test_template.yml
-    if: contains(fromJSON(needs.cicd-test-container-setup.outputs.test_to_run), 'OPTIONAL_L2_Megatron_GPT_Embedding') || needs.cicd-test-container-setup.outputs.all == 'true'
+    if: contains(fromJSON(needs.cicd-test-container-setup.outputs.test_to_run), 'L2_Megatron_GPT_Embedding') || needs.cicd-test-container-setup.outputs.all == 'true'
     with:
       RUNNER: self-hosted-azure
       SCRIPT: |
@@ -3697,7 +3697,6 @@ jobs:
         model.data.test_ds.output_file_path_prefix="/tmp/gpt_embedding_workdir/test_embs" \
         model.data.test_ds.query_file_names=[/home/TestData/nlp/megatron_ir/test_query.jsonl] \
         model.data.test_ds.doc_file_names=[/home/TestData/nlp/megatron_ir/test_doc.jsonl]
-      IS_OPTIONAL: true
 
   L2_Megatron_GPT_PEFT_Lora_PP2_O2:
     needs: [cicd-test-container-setup]
@@ -5162,6 +5161,7 @@ jobs:
   L2_NeMo_2_HF_MODEL_IMPORT:
     needs: [cicd-test-container-setup]
     uses: ./.github/workflows/_test_template.yml
+    if: contains(fromJSON(needs.cicd-test-container-setup.outputs.test_to_run), 'L2_NeMo_2_HF_MODEL_IMPORT') || needs.cicd-test-container-setup.outputs.all == 'true'
     with:
       RUNNER: self-hosted-azure
       SCRIPT: |
@@ -5306,7 +5306,7 @@ jobs:
       #- OPTIONAL_L2_Megatron_GPT_Auto_Configurator_TP1_PP1_MBS124
       - L2_Megatron_GPT_Finetuning_PP2
       - L2_Megatron_GPT_Finetuning_StarCoder_PP1
-      #- OPTIONAL_L2_Megatron_GPT_Embedding 
+      - L2_Megatron_GPT_Embedding
       - L2_Megatron_GPT_PEFT_Lora_PP2_O2
       - L2_Megatron_GPT_PEFT_Lora_TP2_O1
       - L2_Megatron_GPT_PEFT_Lora_TP2SP1
@@ -5337,7 +5337,7 @@ jobs:
       - L2_TTS_Fast_dev_runs_1_Mixer-TTS
       - L2_TTS_Fast_dev_runs_1_Hifigan
       - Speech_Checkpoints_tests
-      #- L2_Stable_Diffusion_Training
+      - L2_Stable_Diffusion_Training
       - L2_NeMo_2_GPT_Pretraining_no_transformer_engine
       #- OPTIONAL_L2_NeMo_2_GPT_DDP_Param_Parity_check
       - L2_NeMo_2_HF_MODEL_IMPORT
@@ -5347,7 +5347,6 @@ jobs:
       - L2_NeMo_2_Mixtral_Pretraining
       - L2_PTQ_Llama2_INT8_SQ
       - L2_PTQ_Llama2_FP8
-      - L2_NeMo_2_HF_MODEL_IMPORT
       - L2_Community_LLM_Checkpoints_tests_Llama3
       - L2_PTQ_Llama2_Export_Only
       - L2_Distill_Llama2