Update examples files #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
requested review from
elezar,
tariq1890 and
cdesiniotis
as code owners
elezar
reviewed
May 13, 2024
| instance: | ||
| type: g4dn.xlarge | ||
| region: us-west-1 | ||
| region: eu-north-1 |
There was a problem hiding this comment.
Is this applicable to most of our users?
There was a problem hiding this comment.
Do we use the AWS_REGION envvar if this isn't specified?
There was a problem hiding this comment.
yes, the aws-sdk pkg does that by default, as well as the key and key_id
There was a problem hiding this comment.
OK, so for the examples we can remove this? or is the intent to provide as complete a spec as possible?
There was a problem hiding this comment.
is to provide an example as complete as posible
examples/v1alpha1_environment.yaml
Outdated
| image: | ||
| architecture: amd64 | ||
| imageId: ami-0ce2cb35386fc22e9 | ||
| imageId: ami-0fe8bec493a81c7da |
There was a problem hiding this comment.
It's not clear what OS we're testing here. Did we ever implement a mapping from OS to image ID?
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
examples/update
branch
from
665ab03 to
3524f4b
Compare
elezar
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.