Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples files #56

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Update examples files #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions examples/aws_kind.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,15 @@ metadata:
spec:
provider: aws
auth:
keyName: eduardoa
privateKey: "/Users/eduardoa/.ssh/eduardoa.pem"
keyName: HOLODECK_AWS_ACCESS_KEY_ID
privateKey: HOLODECK_AWS_SECRET_ACCESS_KEY
instance:
type: g4dn.xlarge
region: eu-north-1
ingressIpRanges:
- 213.179.129.0/26
- <MyIP>/<Range>
image:
architecture: amd64
imageId: ami-0fe8bec493a81c7da
kubernetes:
install: true
installer: kind
Expand Down
18 changes: 12 additions & 6 deletions examples/v1alpha1_environment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,22 @@ metadata:
spec:
provider: aws
auth:
keyName: cnt-ci
privateKey: "/Users/eduardoa/.ssh/cnt-ci.pem"
keyName: HOLODECK_AWS_ACCESS_KEY_ID
privateKey: HOLODECK_AWS_SECRET_ACCESS_KEY
instance:
type: g4dn.xlarge
region: us-west-1
region: eu-north-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this applicable to most of our users?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use the AWS_REGION envvar if this isn't specified?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the aws-sdk pkg does that by default, as well as the key and key_id

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so for the examples we can remove this? or is the intent to provide as complete a spec as possible?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is to provide an example as complete as posible

ingressIpRanges:
- 0.0.0.0/0
- <MyIp>/<Range>
image:
architecture: amd64
imageId: ami-0ce2cb35386fc22e9
architecture: X86_64
containerRuntime:
install: true
name: containerd
nvidiaContainerToolkit:
install: true
nvidiaDriver:
install: true
kubernetes:
install: true
installer: kubeadm
Expand Down
Loading