Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels are displayed in every language #957

Closed
joelit opened this issue Mar 17, 2020 · 1 comment · Fixed by #958
Closed

Labels are displayed in every language #957

joelit opened this issue Mar 17, 2020 · 1 comment · Fixed by #958
Assignees
Milestone

Comments

@joelit
Copy link
Contributor

joelit commented Mar 17, 2020

What steps will reproduce the problem?

  1. Go to the front page of some vocabulary, e.g. YSO
  2. The alphabetical list on the right shows the same concepts several times, these would be the prefLabel in fi, sv and en:
    image
  3. The drop-down search displays the label for every matching language:
    image

What is the expected output? What do you see instead?

Each concept should be displayed once with its suitable label.

It seems that the language parameter is passed incorrectly for the alphabetical listing and the drop-down search results, which means the results are matched in every language.

@osma osma added this to the 2.5 milestone Mar 19, 2020
@osma osma self-assigned this Mar 19, 2020
@osma
Copy link
Member

osma commented Mar 19, 2020

The second problem (search autocomplete) is caused by a case mismatch on this line. The variable is defined in the surrounding query as ?langParam but the all-lowercase ?langparam is used here. It is always unbound so doesn't restrict languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants