Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jena-text searches and alphabetical index restrictions by language #958

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

osma
Copy link
Member

@osma osma commented Mar 19, 2020

Fixes #957

Comes with unit tests that verify the desired result.

@osma osma added this to the 2.5 milestone Mar 19, 2020
@osma osma requested a review from joelit March 19, 2020 14:13
@osma
Copy link
Member Author

osma commented Mar 19, 2020

SonarCloud complains about duplicated code in tests (GenericSparqlTest and JenaTextSparqlTest have many duplicate tests, which only differ in their PHPUnit annotations). This is by design, although not ideal.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #958 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #958      +/-   ##
===========================================
+ Coverage     58.79%   58.8%   +0.01%     
  Complexity     1505    1505              
===========================================
  Files            32      32              
  Lines          4208    4207       -1     
===========================================
  Hits           2474    2474              
+ Misses         1734    1733       -1
Impacted Files Coverage Δ Complexity Δ
model/sparql/JenaTextSparql.php 75% <100%> (+1.22%) 15 <5> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d213da...75c4a57. Read the comment docs.

@joelit
Copy link
Contributor

joelit commented Mar 24, 2020

Looks fine overall. I had some problems running the tests locally, but it doesn't seem to be related to this as everything seems to work in Travis.

@joelit joelit closed this Mar 24, 2020
@osma osma reopened this Mar 24, 2020
@osma osma merged commit 45456a0 into master Mar 24, 2020
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
64.3% 64.3% Duplication

@osma osma deleted the issue957-jena-text-label-lang branch May 6, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels are displayed in every language
2 participants