fixes #934; also adds some tests for upcoming #854

[kouralex]

No description provided.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
5 Code Smells

No Coverage information
2.6% Duplication

[codecov]

Codecov Report

Merging #938 into master will increase coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #938      +/-   ##
============================================
+ Coverage     58.27%   58.60%   +0.32%     
- Complexity     1490     1497       +7     
============================================
  Files            32       32              
  Lines          4168     4189      +21     
============================================
+ Hits           2429     2455      +26     
+ Misses         1739     1734       -5     

Impacted Files	Coverage Δ	Complexity Δ
model/Model.php	81.52% <0.00%> (+1.20%)	105.00% <0.00%> (ø%)	⬆️
model/ConceptPropertyValue.php	82.92% <0.00%> (+3.65%)	46.00% <0.00%> (ø%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b7a02...70aa211. Read the comment docs.

[osma]

The same PR and same commit contains unrelated changes, some addressing #934, others related to #854. This makes it hard to review.

Am I right that the #934 (extra output in tests) changes are the following:

• composer.json update to PHPUnit 7.2+
• tests/FeedbackTest.php add expectNotToPerformAssertions calls
• tests/GlobalConfigTest.php add expectOutputString calls
• tests/RestControllerTest.php add ob_clean() call
• tests/VocabularyTest.php remove print call

...and everything else is related to #854 so out of scope for this PR?

[osma]

@kouralex Can we close this PR? The changes already got merged with the other two PRs, right?

[kouralex]

Good catch @osma, yes, I'll close this now.