Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional fixes for #934 #947

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Conversation

kouralex
Copy link
Contributor

@kouralex kouralex commented Mar 4, 2020

Previously, there were two risky tests as mentioned by #946. These were fixed in #938, however, they got intermingled with issue #854. This PR fixes the remaining risky tests by introducing a new, better sorting for ConceptProperties, and calls appropriate methods for the aforementioned tests.

For testing, please remember to set the skosmos:sortByNotation predicate to true.

@kouralex kouralex requested review from osma and joelit March 4, 2020 13:45
@kouralex kouralex added this to the 2.4 milestone Mar 4, 2020
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #947 into master will increase coverage by 0.13%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #947      +/-   ##
============================================
+ Coverage     58.49%   58.63%   +0.13%     
+ Complexity     1491     1489       -2     
============================================
  Files            32       32              
  Lines          4173     4175       +2     
============================================
+ Hits           2441     2448       +7     
+ Misses         1732     1727       -5
Impacted Files Coverage Δ Complexity Δ
model/ConceptProperty.php 95.83% <86.66%> (-1.31%) 17 <0> (+3)
model/sparql/JenaTextSparql.php 76.36% <0%> (-0.83%) 13% <0%> (-1%)
model/sparql/GenericSparql.php 67.92% <0%> (-0.12%) 303% <0%> (-3%)
model/VocabularyConfig.php 93.25% <0%> (+1.03%) 73% <0%> (-1%) ⬇️
model/ConceptPropertyValue.php 87.95% <0%> (+3.61%) 47% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85d15c...f449ee7. Read the comment docs.

@kouralex kouralex self-assigned this Mar 5, 2020
@joelit
Copy link
Contributor

joelit commented Mar 5, 2020

I ran the tests and resolved a conflict in the test config file. Looking good.

@joelit joelit closed this Mar 5, 2020
@joelit joelit reopened this Mar 5, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joelit joelit merged commit d1865ae into master Mar 5, 2020
@osma osma deleted the issue934-fix-conceptproperty-sort-values branch March 12, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants