[Feat/#8] 공통 레이아웃 설정 #11
Open
+178
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 일관성 있는 레이아웃 스타일 - 페이지 배경색 추가
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jxxunnn
requested review from
a team and
ljh0608
and removed request for
a team
ljh0608
approved these changes
Jan 23, 2025
src/app/global.css
Outdated
There was a problem hiding this comment.
아직 완성된 PR이 아니긴 한데 구경하다가 의문증이 생겨서 찾아왔습니다!
styled components에서 제공하는 api인 createGlobalStyle을 사용하지 않으신 이유가 있으신가요~??
There was a problem hiding this comment.
깜빡했네 ㅠ 스타일 관리는 styled-component가 담당하는 게 좋아보여요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
close #8
작업한 내용
작업 결과
.
비고
URL 구조는 임시로 설정했는데 관련해서는 세션 때 이야기 해보자!
Note
#9 선 병합 필요