-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#8] 공통 레이아웃 설정 #11
+178
−20
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5f641dc
feat: styled-components의 css prop에 대한 타입 선언
Jxxunnn 2c69a01
feat: 최상위 레벨에 레이아웃 컴포넌트 ResponsiveRootLayout 추가
Jxxunnn 9d2b6de
feat: 전역 css 스타일 추가
Jxxunnn cfe5c3d
feat: 메인 컨텐츠 래퍼 컴포넌트 MainContent 추가
Jxxunnn 8c7381e
feat: 헤더 컨텐츠 래퍼 컴포넌트 HeaderContent 추가
Jxxunnn 3fa9e4b
feat: HeaderContent 컴포넌트에 divider prop 추가 및 스타일 개선
Jxxunnn be687c1
feat: 홈, 채팅 페이지, 타로 결과 페이지 레이아웃 구조 정의
Jxxunnn 5cb7233
Merge branch 'main' of https://github.com/Nexters/DDD-web into feat/#8
Jxxunnn b726b34
feat: 타로 결과 페이지 URL 구조 변경
Jxxunnn 8ea8bcd
feat: 전역 css 관리 컴포넌트 GlobalStyle 컴포넌트 추가
Jxxunnn 864ac67
Merge branch 'main' of https://github.com/Nexters/DDD-web into feat/#8
Jxxunnn bf587ab
feat: HeaderContent의 구분선이 전체 화면에 오버플로우 되도록 개선
Jxxunnn 56c799a
chore: 사용하지 않는 파일 삭제
Jxxunnn 1e20149
feat: 전체 화면 배경색 제거
Jxxunnn de945ff
feat: ResponsiveRootLayout 컴포넌트의 배경 및 그림자 스타일 제거
Jxxunnn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
*, | ||
*::before, | ||
*::after { | ||
box-sizing: border-box; | ||
} | ||
|
||
body { | ||
word-break: break-all; | ||
} | ||
|
||
@media screen and (min-width: 450px) { | ||
body { | ||
background-color: rgb(245, 245, 245); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아직 완성된 PR이 아니긴 한데 구경하다가 의문증이 생겨서 찾아왔습니다!
styled components에서 제공하는 api인 createGlobalStyle을 사용하지 않으신 이유가 있으신가요~??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
깜빡했네 ㅠ 스타일 관리는 styled-component가 담당하는 게 좋아보여요
feat: 전역 css 관리 컴포넌트 GlobalStyle 컴포넌트 추가