Skip to content

Commit

Permalink
python3Packages.xmltodict: disable incompatible expat tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonathan Ringer committed Feb 26, 2022
1 parent f704d6a commit 0451c28
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions pkgs/development/python-modules/xmltodict/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
, buildPythonPackage
, fetchPypi
, coverage
, nose
, pytestCheckHook
}:

buildPythonPackage rec {
Expand All @@ -14,11 +14,13 @@ buildPythonPackage rec {
sha256 = "50d8c638ed7ecb88d90561beedbf720c9b4e851a9fa6c47ebd64e99d166d8a21";
};

checkInputs = [ coverage nose ];
checkInputs = [ coverage pytestCheckHook ];

checkPhase = ''
nosetests
'';
disabledTests = [
# incompatibilities with security fixes: https://github.com/martinblech/xmltodict/issues/289
"test_namespace_collapse"
"test_namespace_support"
];

meta = {
description = "Makes working with XML feel like you are working with JSON";
Expand Down

2 comments on commit 0451c28

@vcunat
Copy link
Member

@vcunat vcunat commented on 0451c28 Feb 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More like martinblech/xmltodict#290 I think. My understanding is that tests are not the problem – they only uncovered an incompatibility of the two libraries (in their current versions).

@jonringer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but there's a current work around for it, and upstream should probably react to do a proper fix.

We can always revisit it later.

Please sign in to comment.