Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch namespace separator from colon to pipe (fixes #289) #290

Closed
wants to merge 1 commit into from
Closed

Switch namespace separator from colon to pipe (fixes #289) #290

wants to merge 1 commit into from

Conversation

hartwork
Copy link

Fixes #289

@hartwork hartwork changed the title [DRAFT] Switch namespace separator from colon to pipe (fixes #289) Switch namespace separator from colon to pipe (fixes #289) Feb 27, 2022
@hartwork hartwork marked this pull request as ready for review February 27, 2022 01:19
@exxamalte
Copy link

It should probably be mentioned that this fix does indeed break all parsers that use this library and that parse XML with multiple namespaces, and that have so far relied on the default namespace separator.

@hartwork
Copy link
Author

@exxamalte that's a fair point

@sktzofrenic
Copy link

It should probably be mentioned that this fix does indeed break all parsers that use this library and that parse XML with multiple namespaces, and that have so far relied on the default namespace separator.

Leaving it as is breaks many more projects though.

Thank you @hartwork for doing the legwork on this.

@hartwork
Copy link
Author

hartwork commented Mar 4, 2022

Closing in favor of libexpat/libexpat#577 .

@hartwork hartwork closed this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace separator ':' incompatible with Expat >=2.4.5 <2.4.7 security fixes
3 participants