Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pywemo: disable failing test #124385

Merged
merged 1 commit into from
May 25, 2021

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 25, 2021

Motivation for this change

With libxml2 2.9.12 this test started failing, it was reported upstream
at pywemo/pywemo#268.

Needs to be ported to 21.05.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

With libxml2 2.9.12 this test started failing, it was reported upstream
at pywemo/pywemo#268.
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 124385 at a0160c0 run on aarch64-linux 1

1 package failed to build:
2 packages built successfully:
  • python38Packages.pywemo
  • python39Packages.pywemo

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fabaff fabaff merged commit 5997f0d into NixOS:master May 25, 2021
@mweinelt mweinelt deleted the python/pywemo branch May 25, 2021 15:41
@jonringer
Copy link
Contributor

This is unnecessary with staging-next patch.

@mweinelt
Copy link
Member Author

Let's revert this in staging-next then.

@jonringer
Copy link
Contributor

probably a good solution, so that others don't try to fix the build either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants