Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] python3Packages.pywemo: disable failing test #124395

Merged
merged 1 commit into from
May 25, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

With libxml2 2.9.12 this test started failing, it was reported upstream
at pywemo/pywemo#268.

(cherry picked from commit a0160c0)

Backport #124385

ZHF #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

With libxml2 2.9.12 this test started failing, it was reported upstream
at pywemo/pywemo#268.

(cherry picked from commit a0160c0)
@mweinelt mweinelt requested review from FRidh and jonringer as code owners May 25, 2021 15:34
@mweinelt mweinelt changed the title python3Packages.pywemo: disable failing test [21.05] python3Packages.pywemo: disable failing test May 25, 2021
@ofborg ofborg bot requested a review from fabaff May 25, 2021 15:45
@risicle
Copy link
Contributor

risicle commented May 25, 2021

Got to say, I don't really understand this new libxml2 2.9.12 behaviour. Seems pretty wrong to me. Edit to answer self: most of this is likely due to https://gitlab.gnome.org/GNOME/libxml2/-/issues/255

@mweinelt mweinelt added the 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed label May 25, 2021
@mweinelt
Copy link
Member Author

Might not need to backport this if we fix the libxml2 issue in the first place, so setting this to blocked.

@jonringer
Copy link
Contributor

This builds on staging-next-21.05, where the libxml2 patch was applied

[11:56:41] jon@nixos ~/projects/nixpkgs (staging-next-21.05)
$ nix-build -A python3Packages.pywemo
/nix/store/v3c8dy23556p8d5mx503sk6gwmy2zahk-python3.8-pywemo-0.6.4
[11:56:44] jon@nixos ~/projects/nixpkgs (staging-next-21.05)

@mweinelt mweinelt merged commit 0a1ddb2 into NixOS:release-21.05 May 25, 2021
@mweinelt mweinelt deleted the 21.05/python/pywemo branch May 25, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants