Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.material-shell: 12 -> 40.a #125975

Closed
wants to merge 1 commit into from
Closed

gnomeExtensions.material-shell: 12 -> 40.a #125975

wants to merge 1 commit into from

Conversation

arnarg
Copy link
Contributor

@arnarg arnarg commented Jun 6, 2021

Motivation for this change

Gnome has been updated to 40 and that required all extensions to be changed to be made compatible. Version 12 of material-shell is not compatible with gnome 40 so it does not work with current version of gnome.
This updates material-shell to version 40.a which is compatible with gnome 40.
Since version 12 material-shell has been written in typescript so it needs to be compiled. Therefor I pull in all the development dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@arnarg
gnomeExtensions.material-shell: 12 -> 40.a
a7dd7bf 
Gnome has been updated to 40 and that required all extensions to be
changed to be made compatible. Version 12 of material-shell is not
compatible with gnome 40 so it does not work with current version of
gnome.
This updates material-shell to version 40.a which is compatible with
gnome 40.
Since version 12 material-shell has been written in typescript so it
needs to be compiled. Therefor I pull in all the development
dependencies.
@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 6, 2021
@arnarg arnarg mentioned this pull request Jun 6, 2021
Open
@ofborg ofborg bot requested a review from benley June 6, 2021 16:47
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 6, 2021
@jtojnar
Copy link
Member

jtojnar commented Jun 6, 2021

Did you see #124315?

@arnarg
Copy link
Contributor Author

arnarg commented Jun 6, 2021

@jtojnar I did not. The version supporting Gnome 40 is currently not on extensions.gnome.org afaik should this be added as a manual build to that PR?

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 6, 2021 •
edited
Loading

Result of nixpkgs-review pr 125975 at a7dd7bf run on x86_64-linux 1

1 package built successfully:
  • gnomeExtensions.material-shell
1 suggestion:
  • warning: unused-argument

    Unused argument: nix-gitignore.
    Near pkgs/desktops/gnome/extensions/material-shell/default.nix:1:39:

      |
1 | { stdenv, pkgs, lib, fetchFromGitHub, nix-gitignore, gnome, glib, nodejs }:
  |                                       ^

Result of nixpkgs-review pr 125975 at a7dd7bf run on aarch64-linux 1

1 package built successfully:
  • gnomeExtensions.material-shell

@piegamesde
Copy link
Member

I can drop the commit removing material-shell in my pull request, if the extension now requires manual packaging.

@arnarg
Copy link
Contributor Author

arnarg commented Jun 9, 2021

I don't know what would be best honestly. If the new version of the extension will be pushed to extensions.gnome.org that would be preferable of course. I can ask in their issue tracker.

sei40kr
sei40kr reviewed Jun 27, 2021
View reviewed changes
pkgs/desktops/gnome/extensions/material-shell/default.nix

installPhase = ''
runHook preInstall
mkdir -p $out/share/gnome-shell/extensions/${uuid}
cp -r * $out/share/gnome-shell/extensions/${uuid}/
cp -r dist/* $out/share/gnome-shell/extensions/${uuid}/
runHook postInstall
'';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    license = licenses.mit;

Though not related to this PR, just FYI, mateial-shell is GPL-3.0 license.
https://github.com/material-shell/material-shell

@piegamesde
Copy link
Member

Thanks for your work. The manual packaging has been removed now and a version supporting Gnome 40 has been released, making this obsolete. The next update cycle is currently tracked in #126412.

@piegamesde piegamesde closed this Jul 14, 2021
@tyrion tyrion mentioned this pull request Nov 11, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sei40kr sei40kr sei40kr left review comments

@benley benley Awaiting requested review from benley

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arnarg @jtojnar @r-rmcgibbo @piegamesde @sei40kr