-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnomeExtensions: Auto-update: 26 new, 70 changed. #126412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you! I'm actually really happy about how easy it is to review these. The convention with suffixing the name of the author is a good idea in general, but the extension that we had in first should not be renamed due to backwards compatibility.
Ok. Fixed. It feels crummy picking one of the five hide-activities-button extensions to get the unqualified |
Result of 85 packages built successfully:
|
I totally agree with you. But it is how it is, and the alternatives I've considered so far weren't any better (I once tried collision resolution over all extensions, but then there were dozens with the same name, and most of them long dead). It's also going to be fun in future updates, because we're probably bound to keep the renames forever. (I commented out the 3.38 renames but that was only possible because I didn't have to care about backwards compatibility yet.) |
I think this should definitely be backported to 21.05. Many extensions are currently not ready for gnome 4, rendering them rather useless. |
I'm sorry this takes so long! Please rebase on latest master. If you want, you can also run the update script again since it's been a month (in that case, keep them as two separate commits for reviewing) |
Motivation for this change
I added an extension to the Gnome Extensions database and I'd like to use it in Nix.
Also: This is the first mundane update using the new automatic Gnome extension packaging mechanism. It seems to have gone pretty smoothly. Kudos and thanks to @piegamesde who created the new mechanism in #118232 !
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)