Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions: Auto-update: 26 new, 70 changed. #126412

Closed
wants to merge 1 commit into from

Conversation

chkno
Copy link
Member

@chkno chkno commented Jun 9, 2021

Motivation for this change

I added an extension to the Gnome Extensions database and I'd like to use it in Nix.

Also: This is the first mundane update using the new automatic Gnome extension packaging mechanism. It seems to have gone pretty smoothly. Kudos and thanks to @piegamesde who created the new mechanism in #118232 !

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 9, 2021
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jun 9, 2021
Copy link
Member

@piegamesde piegamesde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I'm actually really happy about how easy it is to review these. The convention with suffixing the name of the author is a good idea in general, but the extension that we had in first should not be renamed due to backwards compatibility.

@chkno chkno force-pushed the gnome-extensions branch from 028ab75 to f5cec70 Compare June 9, 2021 23:19
@chkno
Copy link
Member Author

chkno commented Jun 9, 2021

Great, thank you! I'm actually really happy about how easy it is to review these. The convention with suffixing the name of the author is a good idea in general, but the extension that we had in first should not be renamed due to backwards compatibility.

Ok. Fixed.

It feels crummy picking one of the five hide-activities-button extensions to get the unqualified hide-activities-button name. It feels like picking a 'winner' in some sense — the power of defaults is very strong. I haven't vetted any of these extensions or their authors. But you're right about backwards compatibility; breaking existing configs is also bad. Turning unqualified names into aliases that emit deprecation warnings when a challenger appears feels like more trouble & churn than it's worth. While slightly arbitrary, I guess "first extension to support gnome-shell 38 or 40 wins the unqualified name" is a good-enough naming policy. :)

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 126412 at f5cec70 run on x86_64-linux 1

85 packages built successfully:
  • gnomeExtensions.add-to-desktop
  • gnomeExtensions.add-userhost-to-panel
  • gnomeExtensions.alphabetical-app-grid
  • gnomeExtensions.animation-tweaks
  • gnomeExtensions.app-grid-tweaks
  • gnomeExtensions.appindicator-support
  • gnomeExtensions.applications-menu
  • gnomeExtensions.auto-activities
  • gnomeExtensions.auto-move-windows
  • gnomeExtensions.babar
  • gnomeExtensions.bing-wallpaper-changer
  • gnomeExtensions.blur-my-shell
  • gnomeExtensions.bottom-panel
  • gnomeExtensions.clean-system-menu
  • gnomeExtensions.coverflow-alt-tab
  • gnomeExtensions.cpufreq
  • gnomeExtensions.custom-hot-corners-extended
  • gnomeExtensions.custom-menu-panel
  • gnomeExtensions.customize-ibus
  • gnomeExtensions.ddterm
  • gnomeExtensions.desktop-icons-neo
  • gnomeExtensions.desktop-icons-ng-ding
  • gnomeExtensions.e-ink-mode
  • gnomeExtensions.eclipse
  • gnomeExtensions.espresso
  • gnomeExtensions.executor
  • gnomeExtensions.floating-dock
  • gnomeExtensions.focusli
  • gnomeExtensions.force-show-osk
  • gnomeExtensions.gamemode
  • gnomeExtensions.gnome-40-ui-improvements
  • gnomeExtensions.gnome-citeurl-search-provider
  • gnomeExtensions.gnome-fuzzy-app-search
  • gnomeExtensions.gtile
  • gnomeExtensions.hibernate-status-button
  • gnomeExtensions.hide-activities-button-nmingori
  • gnomeExtensions.hide-top-bar
  • gnomeExtensions.hide-workspace-thumbnails
  • gnomeExtensions.home-assistant-extension
  • gnomeExtensions.ideapad
  • gnomeExtensions.ideapad-mode
  • gnomeExtensions.kitchen-timer
  • gnomeExtensions.krypto
  • gnomeExtensions.launch-new-instance
  • gnomeExtensions.mumbleping
  • gnomeExtensions.mute-spotify-ads
  • gnomeExtensions.native-window-placement
  • gnomeExtensions.no-title-bar-forked
  • gnomeExtensions.non-blocking-switcher
  • gnomeExtensions.nordvpn-connect
  • gnomeExtensions.notification-centerselenium-h
  • gnomeExtensions.notification-counter
  • gnomeExtensions.obmin
  • gnomeExtensions.panel-world-clock-lite
  • gnomeExtensions.places-status-indicator
  • gnomeExtensions.removable-drive-menu
  • gnomeExtensions.round-robin-tab-order
  • gnomeExtensions.run-or-raise
  • gnomeExtensions.runcat
  • gnomeExtensions.screen-lock
  • gnomeExtensions.screenshot-window-sizer
  • gnomeExtensions.scroll-panel
  • gnomeExtensions.shortcuts-for-apt
  • gnomeExtensions.show-desktop-applet
  • gnomeExtensions.shutdowntimer
  • gnomeExtensions.shutdowntimer-mkrajnak
  • gnomeExtensions.spin-down-hard-disk
  • gnomeExtensions.switch-two-layouts
  • gnomeExtensions.time-awareness
  • gnomeExtensions.timezone
  • gnomeExtensions.top-panel-notification-icons
  • gnomeExtensions.translate-clipboard
  • gnomeExtensions.transparent-top-panel
  • gnomeExtensions.transparent-window-moving
  • gnomeExtensions.ubuntu-appearance-gnome-40
  • gnomeExtensions.umi-coin-rate
  • gnomeExtensions.user-id-in-top-panel
  • gnomeExtensions.user-themes
  • gnomeExtensions.vertical-overview
  • gnomeExtensions.volume-mixer
  • gnomeExtensions.wg-indicator
  • gnomeExtensions.window-list
  • gnomeExtensions.windownavigator
  • gnomeExtensions.workspace-indicator
  • gnomeExtensions.you2ber

@piegamesde
Copy link
Member

I totally agree with you. But it is how it is, and the alternatives I've considered so far weren't any better (I once tried collision resolution over all extensions, but then there were dozens with the same name, and most of them long dead). It's also going to be fun in future updates, because we're probably bound to keep the renames forever. (I commented out the 3.38 renames but that was only possible because I didn't have to care about backwards compatibility yet.)

@chkno chkno requested a review from piegamesde June 10, 2021 16:43
@wucke13
Copy link
Contributor

wucke13 commented Jul 5, 2021

I think this should definitely be backported to 21.05. Many extensions are currently not ready for gnome 4, rendering them rather useless.

@piegamesde
Copy link
Member

I'm sorry this takes so long! Please rebase on latest master. If you want, you can also run the update script again since it's been a month (in that case, keep them as two separate commits for reviewing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants