-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpython: 3.9.6 -> 3.9.7; 3.8.11 -> 3.8.12; 3.7.11-> 3.7.12; 3.6.14 -> 3.6.15; 3.10.0-rc1 -> 3.10.0 #136254
Conversation
@ofborg build python38.tests python39.tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 136254 run on x86_64-linux 1
2 packages built:
- python38Packages.requests
- python39Packages.requests
By merging this PR - the following issue (on macOS Big Sur) will be resolved: #105038
Both Python 3.8.12 and Python 3.9.7 contain this patch (python/cpython#27251). |
Two more updates. python36.tests won't run because our numpy version requires at least python37. |
Note 3.6 will be EOL 2021-12, and will thus need to be removed for NixOS 21.11. I suggest changing the package to something else than |
Since python36 is essentially deprecated at this point (no longer being recursed into for derivations), I think it's okay to verify that |
unfortunately, python36Packages.requests seems to fail because of a failure in pytest-xdist |
Marked as security-relevant because of
|
Working on removing Python 3.6 now, since we are nearing the release (8 weeks).
Wondering if these will cause eval errors. Multibootusb is marked as broken and plover requires python2Packages.pillow, which is marked as insecure. |
That's it, no more references to |
Will eventually be fixed by: python/cpython#28153 on next cpython release
@GrahamcOfBorg build python39.tests python38.tests python37.tests |
Bisect says d003f75 "python39: 3.9.6 -> 3.9.7" it broke
|
Filed upstream report as neithere/argh#148 |
Filed another upstream report at aio-libs/aiohttp#6066 |
There are two for
|
(cherry picked from commit 87e4319)
Motivation for this change
https://docs.python.org/release/3.9.7/whatsnew/changelog.html#changelog
https://docs.python.org/release/3.8.12/whatsnew/changelog.html#changelog
https://docs.python.org/release/3.6.15/whatsnew/changelog.html#python-3-6-15-final
https://docs.python.org/release/3.7.12/whatsnew/changelog.html#python-3-7-12-final
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)