Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310: 3.10.0rc1 -> 3.10.0 #140546

Closed
wants to merge 1 commit into from

Conversation

aaronjanse
Copy link
Member

Motivation for this change

https://blog.python.org/2021/10/python-3100-is-available.html

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Note that nix-build -A python310.tests shows some test failures. How should we address these?

nix-build -A python310.tests
______________ Tester.test_class_decorator_respects_staticmethod _______________

self = <tests.test_datetimes.Tester object at 0x7ffff5bb92a0>

    def test_class_decorator_respects_staticmethod(self):
>       assert self.helper() == datetime.date(2012, 1, 14)

tests/test_datetimes.py:450: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

args = (<tests.test_datetimes.Tester object at 0x7ffff5bb92a0>,), kwargs = {}
time_factory = <freezegun.api.FrozenDateTimeFactory object at 0x7ffff5bb9300>

    def wrapper(*args, **kwargs):
        with self as time_factory:
            if self.as_arg and self.as_kwarg:
                assert False, "You can't specify both as_arg and as_kwarg at the same time. Pick one."
            elif self.as_arg:
                result = func(time_factory, *args, **kwargs)
            elif self.as_kwarg:
                kwargs[self.as_kwarg] = time_factory
                result = func(*args, **kwargs)
            else:
>               result = func(*args, **kwargs)
E               TypeError: Tester.helper() takes 0 positional arguments but 1 was given

freezegun/api.py:778: TypeError
=============================== warnings summary ===============================
tests/test_asyncio.py::test_time_freeze_coroutine
/build/freezegun-1.1.0/tests/test_asyncio.py:17: DeprecationWarning: There is no current event loop
    asyncio.get_event_loop().run_until_complete(frozen_coroutine())

tests/test_asyncio.py::test_time_freeze_async_def
<string>:5: DeprecationWarning: There is no current event loop

-- Docs: https://docs.pytest.org/en/stable/warnings.html
=========================== short test summary info ============================
FAILED tests/test_datetimes.py::Tester::test_class_decorator_respects_staticmethod

@mweinelt
Copy link
Member

mweinelt commented Oct 5, 2021

Already on staging as part of #136254.

@mweinelt mweinelt closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants