-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl: trim propagatedBuildOutputs to reduce closure size #157093
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stale
bot
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jul 30, 2022
12 tasks
12 tasks
Artturin
pushed a commit
to Artturin/nixpkgs
that referenced
this pull request
Apr 14, 2023
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
Closing as this was resolved by #226108 |
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Oct 20, 2023
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Oct 20, 2023
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Oct 21, 2023
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Dec 14, 2023
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Dec 22, 2023
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Jan 13, 2024
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
tm-drtina
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Feb 27, 2024
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
tm-drtina
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Apr 8, 2024
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
tm-drtina
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
May 16, 2024
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
tm-drtina
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Jun 7, 2024
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'd like to reduce the closure size of
openssl.dev
by removing thepropagatedBuildOutputs
dependency onopenssl.bin
. This benefits dependencies that don't requireopenssl.bin
, such asnodejs-slim
.This was previously discussed in #125240, which is where I learned about this patch.
With this change, the closure of
openssl.dev
shrinks by 56MB:Before:
After:
The closure size of
nodejs-slim
goes down from 180.4MB --> 126.6MB.I have no idea what this might break. But I think it makes sense for these two outputs to be separate.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes