-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl: remove build-time dependency to host perl #83446
Conversation
r? @peti |
I think in fact the news is still better than that: I believe #19665 was fixed by the same upstream change that makes this change possible. #19965 (comment) |
ping @peti |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Got fixed. |
@SuperSandro2000 Currently in master, openssl still depends on build-time host-platform |
NVM. #115911 did the same thing about 20 days ago. Close as dup. |
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
Motivation for this change
The related code is introduced in #50926 (issue: #50921).
But now the perl script
c_rehash
produced byopenssl.bin
has shebang#!/usr/bin/env perl
, which means we don't need to substitute it anymore.Removing the occurrence of
${perl}
in build script also strip the build-time dependency to host-platform perl, which is actually unused in runtime. This is helpful when cross-compiling openssl, since we don't need to build cross- perl anymore.Note that this PR produce identical outputs (except hashes) to the current ones.
May fix #19965.
Check build dependencies when cross-compiling:
Before the PR: (contains
perl-5.30.1-armv7l-unknown-linux-gnueabihf
)After the PR: (perl-arm is gone)
Things done
sandbox
innix.conf
on non-NixOS linux)openssl
pkgsCross.armv7l-hf-multiplatform.openssl
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)