Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/stage-1: build extraUtils without compiler #213782

Merged
merged 1 commit into from
Feb 3, 2023
Merged

nixos/stage-1: build extraUtils without compiler #213782

merged 1 commit into from
Feb 3, 2023

Conversation

SuperSandro2000
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 requested a review from trofi January 31, 2023 14:12
@SuperSandro2000 SuperSandro2000 requested a review from dasJ as a code owner January 31, 2023 14:12
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 31, 2023
trofi
trofi approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

How did you find it? :)

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 1, 2023
@NickCao NickCao merged commit 96339d7 into NixOS:master Feb 3, 2023
@SuperSandro2000 SuperSandro2000 deleted the stage1-extraUtils branch February 6, 2023 23:02
@SuperSandro2000
Copy link
Member Author

How did you find it? :)

I debugged why when remote building unnecessary packages got copied to the builders and stumbled upon this.

@winterqt
Copy link
Member

winterqt commented Feb 8, 2023

This broke luksroot's YubiKey support: #215243

@Artturin
Copy link
Member

This silently broke stripDirs because runCommand doesn't include bintools. Fix in #244449
Discovered in #207101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trofi trofi trofi approved these changes

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SuperSandro2000 @winterqt @Artturin @trofi @mweinelt @NickCao