Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/stage-1: fix stripping #244449

Merged
merged 1 commit into from
Jul 20, 2023
Merged

nixos/stage-1: fix stripping #244449

merged 1 commit into from
Jul 20, 2023

Conversation

Artturin
Copy link
Member

got broken in 6ea1a2a which changed runCommandCC to runCommand but was not
noticed because it was failing silently

runCommand doesn't include CC or bintools

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin Artturin requested a review from dasJ as a code owner July 20, 2023 05:26
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 20, 2023
@Artturin
Copy link
Member Author

before 25M
after 23M

@Artturin Artturin requested a review from ElvishJerricco July 20, 2023 05:42
@SuperSandro2000
Copy link
Member

was not noticed because it was failing silently

Got that fixed already? We should really make this an hard error

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 20, 2023
@Artturin
Copy link
Member Author

Artturin commented Jul 20, 2023

was not noticed because it was failing silently

Got that fixed already? We should really make this an hard error

#207101 made it error as a side effect, but with a confusing error message.

I'll add checking and a better error message to #244400

got broken in 6ea1a2a which changed
runCommandCC to runCommand but was not
noticed because it was failing silently

runCommand doesn't include CC or bintools
@Artturin Artturin merged commit dbef093 into NixOS:master Jul 20, 2023
@Artturin Artturin deleted the fixsrip1 branch July 20, 2023 22:44
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@Artturin
Copy link
Member Author

nix build -f. nixosTests.systemd-boot fails but it was failing on master

nix build -f. nixosTests.simple builds

K900 added a commit that referenced this pull request Jul 21, 2023
K900 added a commit that referenced this pull request Jul 21, 2023
Artturin pushed a commit that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants