Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3: 3.10 -> 3.11 #249731

Closed
wants to merge 1 commit into from
Closed

Conversation

mweinelt
Copy link
Member

Updates the default python version to 3.11, while keeping 3.10 around until after the NixOS 23.11 release.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Updates the default python version to 3.11, while keeping 3.10 around
until after the NixOS 23.11 release.
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because, why not?

@NickCao
Copy link
Member

NickCao commented Aug 18, 2023

Shall we also update doc/languages-frameworks/python.section.md and the release note?

@raboof
Copy link
Member

raboof commented Aug 25, 2023

Shall we also update doc/languages-frameworks/python.section.md and the release note?

I've created a commit proposing those updates in 4b0b9d0 . I expect there will be some review comments / iteration on getting this 'just right'.

I would propose we merge this PR as-is so we can start ironing out any bugs with python 3.11 ASAP, and iterate on the messaging in parallel.

@mweinelt
Copy link
Member Author

This should go through python-updates, so we can inspect and iterate on the fallout before it hits staging.

cc @tjni do you want to drive this?

@tjni
Copy link
Contributor

tjni commented Aug 25, 2023

Sure thing!

@tjni
Copy link
Contributor

tjni commented Aug 27, 2023

I have been working on addressing some fallout from #248866, but I'll start working on this tomorrow.

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 6, 2023
@mweinelt
Copy link
Member Author

Continues on python-updates.

@mweinelt mweinelt closed this Sep 12, 2023
@mweinelt mweinelt deleted the python311-default branch September 12, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

7 participants